Update the global ip pool#1056
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the IP Pool documentation to reflect newer selection behavior, especially around the “global” IP pool concept and how spec.selector.network affects eligibility.
Changes:
- Clarifies that only one global IP pool is allowed per network and that global pool fallback must match the LB’s network.
- Expands the description of the
loadbalancer.harvesterhci.io/networkannotation behavior when not set. - Updates the global IP pool YAML example to include
selector.networkand adds a version note about empty.spec.selector.network.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
w13915984028
force-pushed
the
doc10592-globalpool
branch
from
97a8bf6 to
0f9f741
Compare
|
w13915984028
force-pushed
the
doc10592-globalpool
branch
2 times, most recently
from
5d49d3e to
48a2aa3
Compare
Signed-off-by: Jian Wang <jian.wang@suse.com>
w13915984028
force-pushed
the
doc10592-globalpool
branch
from
48a2aa3 to
d7e212b
Compare
martindekov
approved these changes
Jun 3, 2026
martindekov
left a comment
martindekov
left a comment
Member
There was a problem hiding this comment.
I don't have anything to add LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Amend the document to reflect the latest updates on loadbalancer global IP Pool.
Solution:
Related Issue(s):
issue: harvester/harvester#10592
PR: harvester/harvester#10197
Test plan:
Additional documentation or context